Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please create a ComfyUI node to use SageAttention #37

Open
wardensc2 opened this issue Nov 11, 2024 · 4 comments
Open

Please create a ComfyUI node to use SageAttention #37

wardensc2 opened this issue Nov 11, 2024 · 4 comments

Comments

@wardensc2
Copy link

Hi @jt-zhang

Thank you so much for your work however for normal people like us it's very difficult to understand your code and implement it on normal you. Can you write a Comfy Node for us to use Sage Attention easier

Thank in advance

@jason-huang03
Copy link
Member

jason-huang03 commented Nov 11, 2024

Sorry we are not familiar with Comfy. However, I have read blogs that claim to use SageAttention with Comfy like this. Perhaps you can refer to them. The Comfy community is quite active and I believe there are ready solutions to the problem.

@jason-huang03
Copy link
Member

Also the mochi node supports using SageAttention.

@blepping
Copy link

blepping commented Nov 30, 2024

I added an enhanced SageAttention node to my ComfyUI-bleh node pack. The BlehSageAttentionSampler will enable SageAttention just while a specific sampler is running which has less chance of causing issues than monkeypatching ComfyUI's attention globally. You can also choose to have it enabled for part of sampling.

image

Note: This image is just an example of how you could pass parameters if you need to, not a recommendation.

You can select the kernel or pass parameters to the attention function directly via a YAML text input. Note: Doing stuff like messing with sm_scale is not recommended/supported so if you enter weird parameters and stuff breaks don't bug the SageAttention authors about it.

@jt-zhang
Copy link
Member

jt-zhang commented Dec 7, 2024

Thank you for the valuable suggestion and contribution. We are also continuously improving and updating more features. You can Star and Watch our repository to stay updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants