Skip to content
This repository has been archived by the owner on Feb 11, 2024. It is now read-only.

Supply absolute path to file instead of relative #23

Open
dyereh opened this issue Oct 6, 2022 · 3 comments
Open

Supply absolute path to file instead of relative #23

dyereh opened this issue Oct 6, 2022 · 3 comments

Comments

@dyereh
Copy link

dyereh commented Oct 6, 2022

I noticed some programs (for me drawio) may require you to send the absolute path to open the file correctly (for drawio, if you send the relative path it just opens a blank diagram).

I'm thinking we can just add expand-file-name in the correct places in the dired-launch-with-prompt-command and a small change to dired-launch-command. Would this be worthwhile to look into/have any adverse effects I'm not thinking of.

I can submit a PR if this sounds like a useful change

@dyereh
Copy link
Author

dyereh commented Oct 6, 2022

For some reason, my drawio seems to work fine with relative paths now.. no idea why.. I still wonder if it would be useful to expand to the abs path regardless?

@thomp
Copy link
Owner

thomp commented Oct 7, 2022

I don't think the absolute path idea is a bad one -- in the context of dired-launch, removing ambiguity by using absolute paths should result in identical behavior in most cases. I have a hard time imagining a situation in which it would be problematic to provide an absolute path -- and don't recollect the rationale, if any, for invoking DIRED-GET-MARKED-FILES with LOCALP set to T. If you find a few spare minutes to put something together, a PR certainly would be welcome.

@dyereh
Copy link
Author

dyereh commented Nov 1, 2022

Apologies for such a delay - I will try to get to this in the next few weeks & submit a PR. Until then, not sure if you want to leave this issue open?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants