Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favouriting / Unfavouritong a course does not respect custom order of courses #25

Open
pkgh opened this issue Aug 3, 2018 · 1 comment

Comments

@pkgh
Copy link

pkgh commented Aug 3, 2018

I have experienced such behaviour when favouriting & unfavouriting courses:

  1. I keep complete list of courses including favouitited ones in the courses list (i.e. keepfavourites is selected)
  2. Favouriting a course copies it into the Favourites panel AND moves it to the bottom of the course List.
  3. Unfavouriting the course remioves the star AND KEEPS that course at the bottom of the course list.

I would expect the original position of the course to be remembered when it is favourited and restored when it is unfavourited.

(Moodle 3.5.1 on Debian 9.4, MariaDB 10.1.26, PHP 7.0.30.0.9.1, Apache 2.4.25, Fordson theme with Boost presets.)

@thepurpleblob
Copy link
Owner

Hmmm.... they are separate lists. The weighting is not (as you note) retained when it moves from list to list. It is just added on the end.

I agree it would be nice but would require quite a big change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants