Sorting adds all courses to favourites

[sarahjcotton]

We were hoping to use this block as a replacement for the my_over block which as you know is not yet fully developed, however I have found that all courses are added to favourites when following the steps below which would be frustrating for users who have a lot of courses to manage:

1. Make sure no favourites are selected
2. Add a course to favourites
3. Turn editing on
4. Click on Favourites
5. Change sort order to full name
6. Click on Courses tab
7. Move a course
8. Click on favourites
9. Change sort order to drag and drop
10. All courses are added to favourites

This was tested with Moodle 3.5 using Clean theme with the my_overview block disabled.

[thepurpleblob]

I've not been able to reproduce this behaviour. Do you have any more information?

[tristdac]

I'm having the same issue as Sarah, but found a quicker way to recreate. I've actually found that if you try to move a course while on the courses tab, then stop editing, the favourites and courses lists are reversed. (this will be dependant on your sites 'Keep favourites in course list' setting.

1. Mark a single course as favourite (if you mark more than 2, you'll be able to reverse it back again later)
2. Editing on
3. Select Drag'n'drop sort order
4. Courses Tab
5. Move any course to any location
6. Stop editing

Your courses list has now become your favourites (and vice-versa if Keep favourites in course list is set to no)

You can then repeat these steps and your favourites/courses will switch back again.

Tested and confirmed in v2018070400 & v2018053000 and on multiple servers.
Moodle v3.4.4

EDIT: After testing a bit more, it looks like this occurs when you try moving a course on a tab that isn't the default active tab upon page load. So if your default tab is Courses, move a course on the Favourites tab.

[jsi22]

We are also having the same problem with this block. Installed on Moodle 3.4.4.

After drag and drop on course list, click "stop customising page", the course list and favourites list are reversed.

[mepfaff]

Same issue with 3.4. Here's what I did:

1. Have no courses in favorites and Sort order set to "Drag-and-drop order"
2. Add the topmost course to favorites. This will take you to the favorites tab.
3. Return to the Courses tab. The favorited course will have been moved to the bottom.
4. "Customize this page"
5. Drag-and-drop the favorited course upwards one or more in the order.
6. "Stop customizing"
7. All courses now in favorites.

[thepurpleblob]

Will have a proper look at this next week. Been tied up with some other stuff.

[seanru]

We're also having the same issue in Moodle 3.5 . The process identified by Tristdac is exactly what we have experienced.

[thepurpleblob]

I'm currently doing a load of work on this block to fix these issues and add some suggested new features. Bear with me, I'll get this sorted out.

[thepurpleblob]

I am unable to reproduce this. Can somebody check with the latest version and see if it is still an issue?

[jstilwell]

Hello,

We are experiencing this same problem in Moodle 3.5.8 using the same steps as indicated above.