Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility of ep.pp.mice_forest_impute with different datatypes #851

Open
2 tasks
eroell opened this issue Jan 8, 2025 · 1 comment
Open
2 tasks

Compatibility of ep.pp.mice_forest_impute with different datatypes #851

eroell opened this issue Jan 8, 2025 · 1 comment
Assignees
@aGuyLearning
Labels
enhancement New feature or request

Comments

@eroell
Copy link
Collaborator

eroell commented Jan 8, 2025

Description of feature

Follow the template workflow of #835:

  • introduce singledispatch to check for allowed data types, or raise an error if others are encountered
  • adapt the tests to check these data types
@eroell eroell added the enhancement New feature or request label Jan 8, 2025
@eroell
Copy link
Collaborator Author

eroell commented Jan 8, 2025

I think for now, the way to go here could be to accept only numpy arrays, and raise NotImplementedError for the others, as it could be a non-trivial effort to support them worth only once we get a request for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aGuyLearning aGuyLearning

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aGuyLearning @eroell