Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent versioning? #28

Open
achuinard opened this issue Jun 18, 2019 · 1 comment
Open

Inconsistent versioning? #28

achuinard opened this issue Jun 18, 2019 · 1 comment

Comments

@achuinard
Copy link

I'm having an issue with my app using this library. Recently, it appears the PieRotateListener had a second method added to it. Fine.

However, the listener does not trigger on done when using startLuckyWheelWithTargetIndex.

My source locally looks like:

        float targetAngle = ((360f * mRoundOfNumber * rotationAssess) + 270f - getAngleOfIndexTarget(indexResult) - (360f / mLuckyItemList.size()) / 2);
        animate()
                .setInterpolator(new DecelerateInterpolator())
                .setDuration(mRoundOfNumber * 1000 + 900L)
                .setListener(new Animator.AnimatorListener() {
                    @Override
                    public void onAnimationStart(Animator animation) {
                        isRunning = true;
                    }

                    @Override
                    public void onAnimationEnd(Animator animation) {
                        setRotation(getRotation() % 360f);
                        if (mPieRotateListener != null && predeterminedNumber > -1) {
                            mPieRotateListener.rotateDone(predeterminedNumber);
                        }
                    }

Your source of the same line doesn't mention the predeterminedNumber, instead triggering with the index of what was completed.

What's going on? I can't even get the older version of the library that used to work right with the way this library is versioned. There really should be versions cut and not just have users use the master snapshot in Gradle.

@achuinard
Copy link
Author

achuinard commented Jun 18, 2019

Actually, looking at your source in master, your PieRotateListener interface still only has 1 method rotateDone. I'm very confused as to why my source has onRotationStart as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant