Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to compose v2 #659

Closed
jalaziz opened this issue Oct 4, 2023 · 2 comments · Fixed by #681
Closed

Default to compose v2 #659

jalaziz opened this issue Oct 4, 2023 · 2 comments · Fixed by #681
Labels
enhancement New feature or request

Comments

@jalaziz
Copy link
Contributor

jalaziz commented Oct 4, 2023

It seems that the current version of testcontainers first attempts to use compose V1, then tries V2.

In environments where both V1 and V2 are installed (e.g. GitHub Actions), this will always default to V1 with no easy option to use the newer version.

Since V1 is deprecated, testcontainers should probably default to V2. Alternatively, it would be great if there was a way to override the default.

@cristianrgreco cristianrgreco added the enhancement New feature or request label Oct 20, 2023
@daniel-glazer
Copy link

hey, looks like a good first issue to me.. can I take it?
can you share a link to the guide on how to contribute? @cristianrgreco

@danielglazer
Copy link
Contributor

prefer to open a PR via my personal GitHub account...
couldn't find contributing.md file for this project.
if still needed I would just need to know if direct PR acceptable or some other way is better to submit changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants