-
-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce a TC_HOST env variable in node.js implementation of testcontainers #580
Comments
Hi @roman-dzhadan, thanks for raising the issue and I agree. I will speak with the other testcontainers maintainers to see how to get this done. |
Hey, can I help with this issue? looks to me like we can support both for backward compatibility to not make any breaking changes. but want to hear from you if this looks like a good idea |
@danielglazer It's a tricky issue to pick up because there's a lot of context. Testcontainers supports the concept of a We'll need to come up with something more generic and agree it with the other Testcontainer implementations, it's just low priority at the moment. IMO something like If you're looking for an issue to contribute I'd suggest #661 |
@cristianrgreco I am looking for another issue to contribute to :) will definitely check it out. thanks again 🚀 |
I'm not understanding the benefit. Testcontainers (and Devcontainers) require Docker API regardless of implementation: Rancher Desktop, Colima, Podman, Moby, etc. These developer tools are distinctly different from Kubernetes, which requires only a runtime interface (CRI) and has removed the dockerd runtime. Perhaps I'm missing something, but I don't see how introducing a new env var is going to change this reality. The TestContainers Java docs spell out DOCKER_HOST, too: https://java.testcontainers.org/supported_docker_environment/ In fact, the Testcontainers docs have helped me sort-out my docker-related issues in other (non-TC) contexts. |
Intro
Python, Ruby, and Go implementations support TC_HOST env variable.
This is a logical naming convention for those who are not using Docker as their runtime containers.
Currently, Node implementation of testcontainers only supports DOCKER_HOST which is a non-logical naming convention for those who are not using Docker as their runtime containers.
@cristianrgreco, lately, I've seen you've made a lot of great improvements to make Podman & Node.js Testcontainers more compatible. What do you think about my suggestion?
Expected Behaviour
Improved API consistency of Node implementation to make the experience of usage testcontainers more language-agnostic.
Actual Behaviour
According to the documentation, I must define the DOCKER_HOST variable even if I use Podman. Which is non-logical behaviour to me.
Steps to Reproduce
Environment Information
The text was updated successfully, but these errors were encountered: