Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation notice in console #2102

Closed
tshimber opened this issue Aug 16, 2023 · 5 comments · Fixed by #2139 or #2183
Closed

Deprecation notice in console #2102

tshimber opened this issue Aug 16, 2023 · 5 comments · Fixed by #2139 or #2183
Labels
bug Something isn't working

Comments

@tshimber
Copy link
Contributor

Scale Version
3.0.0-beta.137

Framework and version
VUE 3.3.4

Current Behavior
Disturbing noticies:
image

Expected Behavior
No noticies

Code Reproduction
These are my first tries in vue, maybe it's all incorrect. But I don't use any lang props
image

@felix-ico
Copy link
Collaborator

Hi @tshimber, sorry for the late reply. I understand these deprecation warnings can be annoying and i opened a PR to remove the default language that is set on the logo component (causing the deprecation warning even when the end user doesn't set any language).

By the way I notice that you are using scale-app-shell and scale-app-footer, just FYI these components have been deprecated, and replaced by scale-telekom-app-shell, scale-telekom-footer and scale-telekom-header.

@tshimber
Copy link
Contributor Author

tshimber commented Sep 22, 2023

Hi @felix-ico
not so late honestly) thanks for answering!!
thank you, will be good not to have those notifications, but it's not critical of course.
considering deprecated components - we just use them in lots of templates for diff frameworks, need to make a task to update everywhere🙃

@tshimber
Copy link
Contributor Author

@felix-ico Felix, hi! sorry to bother you again, maybe you can tell: how can I get, if thing is or isn't fixed without bothering you? I've updated Scale to latest 3.0.0-beta.142, but I still see the warning. I use deprecated scale-app-shell, as you correctly noticed, but your comment looked like it will be fixed for old ones as well.
It's not critical, but just for me to understand if it will be fixed for deprecated scale-app-shell and to move or don't move it from my list)

Thanks!!

@felix-ico
Copy link
Collaborator

felix-ico commented Oct 30, 2023

hey @tshimber, looks like i forgot to remove the language attribute from the footer, so that's why you were getting the warnings. The header should not throw any warnings though. Normally we wouldn't push updates to deprecated components but this was simple enough to do #2183

@tshimber
Copy link
Contributor Author

☺☺☺ so nice from you:) thanks a lot!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants