Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coerce to same dtype and warn if images are not the same dtype #4

Open
alisterburt opened this issue Aug 9, 2024 · 1 comment
Open
Labels
good first issue Good for newcomers

Comments

@alisterburt
Copy link
Collaborator

This implementation doesn't handle when a and b are of different types

    def _normalised_cc_complex_1d(a: torch.Tensor, b: torch.Tensor):
>       correlation = torch.dot(a, torch.conj(b))
E       RuntimeError: dot : expected both vectors to have same dtype, but found ComplexDouble and ComplexFloat

ideally this would be smart and aware of relative precisions of difference types but doesn't matter in the first instance

@sjrothfuss or @milesagraham maybe you'd like to take this on? no pressure of course, just let me know if you're planning to work on it

@alisterburt alisterburt added the good first issue Good for newcomers label Aug 9, 2024
@sjrothfuss
Copy link

I'm interested in helping but realistically couldn't take this on until at least mid September.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants