Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plan for ImodModel creation API and point2model function #25

Open
alisterburt opened this issue Dec 10, 2024 · 0 comments
Open

plan for ImodModel creation API and point2model function #25

alisterburt opened this issue Dec 10, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@alisterburt
Copy link
Collaborator

following from discussion in #24 here is a proposed API that will simplify creation of ImodModels for writing out with the new imodmodel.write() function (thanks @jojoelfe !)

  • Contour.from_numpy(arr: np.ndarray)
  • Object.from_contours(contours: list[Contour])
  • ImodModel.from_objects(objects: list[Object])

We also want a convenience API available at the top level of imodmodel for creating models

  • imodmodel.point2model(points: np.ndarray) -> ImodModel

@uermel suggested he may find time to implement this in the near future

@alisterburt alisterburt added the enhancement New feature or request label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant