Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat]: Can we have support for emojies in Story titles? #573

Open
Deliaz opened this issue Sep 9, 2024 · 1 comment
Open

[feat]: Can we have support for emojies in Story titles? #573

Deliaz opened this issue Sep 9, 2024 · 1 comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request

Comments

@Deliaz
Copy link

Deliaz commented Sep 9, 2024

It would be nice to have support for emojis in the story title.
From what I can see, the story titles are being used to create a virtual file structure, and it is currently impossible to use anything beyond acceptable JS variable names.

It seems like changes are needed in the naming utilities: packages/ladle/lib/cli/vite-plugin/naming-utils.js.
I can try to make those changes if given some direction.

Thanks!

@Deliaz Deliaz added the needs triage needs to be reviewed label Sep 9, 2024
@tajo tajo added duplicate This issue or pull request already exists enhancement New feature or request and removed needs triage needs to be reviewed labels Sep 28, 2024
@tajo
Copy link
Owner

tajo commented Sep 28, 2024

similar to #569

while we use story titles to create the IDs/navigation, we could preserve the original value in a new property and use that solely for the sidebar navigation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants