From 4c33d3204a7d9c4223a765e3833e42b88d01f28a Mon Sep 17 00:00:00 2001
From: Tabulo <dev@tabulo.net>
Date: Mon, 27 Sep 2021 16:40:39 +0200
Subject: [PATCH] Update ChangeLog, remove "TODO" mark from tests related to
 #1508

This is made in a separate commit so to ease cherry-picking
between two alternative fixes proposed in distinct commits.

In any case, all tests pass either way.

CHANGES:
=============
modified: t/issue/1508.t
modified: ChangeLog

HOW TO TEST :
=============
$ prove -v t/issue/1508.t   # for this issue
$ prove t/**/*.t            # for non-regression
---
 ChangeLog      | 1 +
 t/issue/1508.t | 4 ++--
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 2fa7c11b8..df6d70e97 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -5,6 +5,7 @@ Revision history for Rex
 
  [BUG FIXES]
  - Detect invalid hostgroup expressions
+ - Propagate args/params down to "needed" tasks launched by needs()
 
  [DOCUMENTATION]
 
diff --git a/t/issue/1508.t b/t/issue/1508.t
index a1ec556b4..794e59667 100644
--- a/t/issue/1508.t
+++ b/t/issue/1508.t
@@ -144,9 +144,9 @@ task test6 => sub {
   T::check_needed( $_, { argv => \@_ } ) for (qw/test /);
 };
 
-TODO: {
-  local $TODO = "Issue 1508: The needs() function should propogate parameters/args";
 
+
+{
   my $task_list = Rex::TaskList->create;
   my $run_list  = Rex::RunList->instance;
   $run_list->parse_opts(qw/test test2 test3 test5 test6/);