Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mosquitto] ExternalTrafficPolicy can only be set on NodePort and LoadBalancer service #158

Open
link-webcreations opened this issue Oct 8, 2021 · 1 comment
Open

[mosquitto] ExternalTrafficPolicy can only be set on NodePort and LoadBalancer service #158

link-webcreations opened this issue Oct 8, 2021 · 1 comment

Comments

@link-webcreations
Copy link

Hello,

The PR #154 introduce the following bug in K8S 1.21:

Service is invalid: spec.externalTrafficPolicy: Invalid value: "Cluster": ExternalTrafficPolicy can only be set on NodePort and LoadBalancer service

The parameter ExternalTrafficPolicy cannot be used if type: ClusterIP.

A quick fix could be:

{{- if ne .Values.service.type "ClusterIP" }}
  externalTrafficPolicy: {{ .Values.service.externalTrafficPolicy }}
{{- end }}

What do you think of it?
@link-webcreations link-webcreations changed the title ExternalTrafficPolicy can only be set on NodePort and LoadBalancer service [mosquitto] ExternalTrafficPolicy can only be set on NodePort and LoadBalancer service Oct 8, 2021
@helmecke helmecke mentioned this issue Jan 3, 2022
Closed
@wkhatch
Copy link

wkhatch commented Dec 30, 2022

why is this closed and the corresponding fix commit not in current head?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(moquitto): ExternalTrafficPolicy
2 participants
@wkhatch @link-webcreations