Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extractor: Create and use wrapper for TumblrAPI #111

Open
syeopite opened this issue Oct 14, 2024 · 0 comments
Open

Extractor: Create and use wrapper for TumblrAPI #111

syeopite opened this issue Oct 14, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@syeopite
Copy link
Owner

syeopite commented Oct 14, 2024

Sometimes Tumblr's official client uses weird ways to request certain data.

For example for post reblog notes, the reblogs only filter will request an entirely different endpoint from the other filters.

Not to mention the weird route names they use.

Implementing all this behavior into the route logic complicates things and makes maintenance harder.

We should create and use a wrapped version of TumblrAPI that implements these unique behaviors and simplifies the method names for understanding.

Example of what the wrapper could do:

hubs_timeine --> get_tagged_posts
blog_posts(...) --> get_blog_posts
blog_posts(... tag="example") --> get_tagged_posts_from_blog

@syeopite syeopite added the enhancement New feature or request label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant