Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Swift 6.0? #963

Open
groue opened this issue Jan 14, 2025 · 2 comments
Open

Support for Swift 6.0? #963

groue opened this issue Jan 14, 2025 · 2 comments

Comments

@groue
Copy link
Contributor

groue commented Jan 14, 2025

Hello,

The project_precommit_check script mentioned in the pull request template is limited to Swift up to 5.10.

As a consequence, one can't submit a pull request that targets Swift 6.0, and pass pull request requirements.

@groue
Copy link
Contributor Author

groue commented Jan 14, 2025

I submitted a pull request for GRDB/Swift6.0 anyway: #964

@groue
Copy link
Contributor Author

groue commented Jan 14, 2025

I forgot to add that the pull request template does not provide the correct way to call project_precommit_check. It says:

pass ./project_precommit_check script run

This is not... accurate as it should be. For an example of a real way to call it, see: #792. That's how it is supposed to be called:

./project_precommit_check GRDB.swift --earliest-compatible-swift-version 5.7

And it is not easy to guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant