Drop logind integration #133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This integration is unwanted, as expressed in #117. Additionally, the integration is not quite correct; to properly launch a screen locker before sleeping, swayidle should set a suspend inhibitor **at startup**, and upon the PrepareForSleep signal, it should start the screen locker and then release the inhibitor lock. The existing implementation is racey and may run the locker _after_ resuming from suspend. Fixes: #117 Closes: #127 Closes: #121 Closes: #64 Closes: #59 Closes: #125 Closes: #89
|
Looks good. A possible replacement for users is https://git.sr.ht/~whynothugo/systemd-lock-handler |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This integration is unwanted, as expressed in #117.
Additionally, the integration is not quite correct; to properly launch a
screen locker before sleeping, swayidle should set a suspend inhibitor
at startup, and upon the PrepareForSleep signal, it should start the
screen locker and then release the inhibitor lock. The existing
implementation is racey and may run the locker after resuming from
suspend.
Fixes: #117
Closes: #127
Closes: #121
Closes: #64
Closes: #59
Closes: #125
Closes: #89