-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Component & file names comment markup is missing in svelte v5 #14952
Comments
I can't reproduce this - opening your Stackblitz link for v4 does not show any comments, nor can I remember that we ever had something like this in dev mode. Could this be from another source? An extension adding these, etc ? |
I'm seeing those comments in the v4 StackBlitz. I do also recall seeing them before. I don't have any extensions that would be adding them. I'm seeing them both in Firefox and in Chromium. |
I'm also seeing those comments in the v4 StackBlitz and I do also recall seeing them before. |
The screenshots are from the stackblitz repo. Are you inspecting the correct element? (It should be inside an iframe) |
Apologies, I must've looked in the wrong place, I see them too, though I really don't recall that part of the compiler. @Conduitry is this some dev only thing that was present once? Looking at the compiler output of v4 there's nothing obvious standing out. |
This comment was marked as outdated.
This comment was marked as outdated.
I also couldn't find the logic anywhere. I looked in svelte-4 branch & in the vite-plugin-svelte repo. |
Describe the bug
In svelte v4, the markup in dev mode would contain the file name & components names in the html markup as comments. Here's a screenshot:
But in svelte v5, the markup now omits the file name & comment names in dev mode, making it hard to parse the markup in large apps.
Reproduction
For v4:
https://stackblitz.com/edit/sveltejs-kit-template-default-k8mk4s?file=package.json
For v5:
https://stackblitz.com/edit/sveltejs-kit-template-default-xkgpk8fk?file=package.json
Logs
No response
System Info
Severity
blocking an upgrade
The text was updated successfully, but these errors were encountered: