From 02a5a48cdd004a57c038f99f135020d5c0d82459 Mon Sep 17 00:00:00 2001 From: TheDude Date: Wed, 8 Jan 2025 23:17:27 +0530 Subject: [PATCH 1/2] Small bug in sqlalchemy reconnect --- plugins/sqlalchemy/superduper_sqlalchemy/metadata.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/sqlalchemy/superduper_sqlalchemy/metadata.py b/plugins/sqlalchemy/superduper_sqlalchemy/metadata.py index 1a641dee2..3e71ac971 100644 --- a/plugins/sqlalchemy/superduper_sqlalchemy/metadata.py +++ b/plugins/sqlalchemy/superduper_sqlalchemy/metadata.py @@ -203,7 +203,7 @@ def commit(self): def reconnect(self): """Reconnect to sqlalchmey metadatastore.""" - sql_conn = create_engine(self.uri) + sql_conn, name = self.connection_callback() self.conn = sql_conn # TODO: is it required to init after From 12120ab929991f00443696102fbedcef215cfb26 Mon Sep 17 00:00:00 2001 From: TheDude Date: Wed, 8 Jan 2025 23:18:02 +0530 Subject: [PATCH 2/2] Update changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8fe7ef338..6751c9808 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -55,6 +55,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Fix the frontend rendering issue related to choices when it is set to /describe_tables. - Fix the error when using batch apply with dataset. - Fix the bug of mismatched data types in the diff within the update mechanism. +- Fix a small bug in sqlachmey reconnect ## [0.4.0](https://github.com/superduper-io/superduper/compare/0.4.0...0.3.0]) (2024-Nov-02)