Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DATATYPE] Create base DataType without all parameters and use it for "switch" Vector type #2629

Closed
Tracked by #2562
blythed opened this issue Nov 19, 2024 · 0 comments
Closed
Tracked by #2562

[DATATYPE] Create base DataType without all parameters and use it for "switch" Vector type #2629

blythed opened this issue Nov 19, 2024 · 0 comments

Comments

@blythed
Copy link
Collaborator

blythed commented Nov 19, 2024 •
edited
Loading

The base Datatype contains many extraneous parameters, which we don't necessarily need (encoder for example).
We should add an intermediate class in the hierarchy to solve this, which we can subclass with Vector.

Vector will have its encode implementation based on this suggestion: #2562 (comment)
@blythed blythed mentioned this issue Nov 19, 2024
Open
8 tasks
@blythed blythed changed the title [DATATYPE] Create base Datatype without all parameters and use it for "switch" Vector type [DATATYPE] Create base DataType without all parameters and use it for "switch" Vector type Nov 19, 2024
@blythed blythed mentioned this issue Nov 21, 2024
Merged
@blythed blythed moved this from To Do to Review in superduper-open-source Nov 21, 2024
@blythed blythed closed this as completed Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
superduper-open-source
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@blythed