You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Practically, these were never encountered (found them in a synthetic test) and they seem to be unused. I guess these property assignments can be removed
Issue arose bc synthetic tests disabled #[AllowDynamicProperties] which is declared in wpdb.
I guess these properties (and others like $this->table) should be declared eventually though.
https://github.com/stuttter/ludicrousdb/blob/master/ludicrousdb/includes/class-ludicrousdb.php#L821
Same for "$dataset" in https://github.com/stuttter/ludicrousdb/blob/master/ludicrousdb/includes/class-ludicrousdb.php#L738C4-L738C30
current_host https://github.com/stuttter/ludicrousdb/blob/master/ludicrousdb/includes/class-ludicrousdb.php#L880
last_connection https://github.com/stuttter/ludicrousdb/blob/master/ludicrousdb/includes/class-ludicrousdb.php#L891
callback_result https://github.com/stuttter/ludicrousdb/blob/master/ludicrousdb/includes/class-ludicrousdb.php#L891 (doesn't need to be property)
Practically, these were never encountered (found them in a synthetic test) and they seem to be unused. I guess these property assignments can be removed
The text was updated successfully, but these errors were encountered: