🐛 Bug Report: OIDC Client Details wrong value for PKCE

[simon-eller]

Reproduction steps

1. Navigate to "OIDC Clients" and "Add OIDC Client"
2. Enter credentials and uncheck "PKCE" and click on "Save"
3. In the details click on "Show more details"
4. Option PKCE is Disabled
5. Now check "PKCE" save it again and the value of PKCE is still displayed as Disabled

Expected behavior

The value of PKCE should be displayed as Enabled if it is enabled.

Actual Behavior

No matter if PKCE is checked or unchecked it is always displayed as Disabled

[simon-eller]

I think i found the issue in frontend/src/routes/settings/admin/oidc-clients/[id]/+page.svelte at line 30:

PKCE: client.isPublic ? 'Enabled' : 'Disabled'

should be

PKCE: client.pkceEnabled ? 'Enabled' : 'Disabled'

[parhammhd]

I have the same issue as well, not sure if that is the case but I am getting errors trying to use Pocket ID for Pingvin Share possibly because of not being able to enable PKCE.

[stonith404]

think i found the issue in frontend/src/routes/settings/admin/oidc-clients/[id]/+page.svelte at line 30:

Yes thanks, that's the issue.

[stonith404]

@parhammhd It's just a display bug. Everything should still work as expected.

Pingvin Share doesn't support PKCE so you have to disable it. Which error do you get?

[parhammhd]

@parhammhd It's just a display bug. Everything should still work as expected.

Pingvin Share doesn't support PKCE so you have to disable it. Which error do you get?

Thanks, it fixed my issue, just had to disable it 😁🙏🏻

[stonith404]

This should be fixed in v0.24.0

[simon-eller]

Thanks a lot! Btw very cool project. 👍🏼