Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example crashed on Android #2

Open
nhatquya opened this issue Dec 22, 2016 · 5 comments
Open

Example crashed on Android #2

nhatquya opened this issue Dec 22, 2016 · 5 comments

Comments

@nhatquya
Copy link

nhatquya commented Dec 22, 2016

I've implement your code and app crashed on Android.
I solved this problem by wrap <Svg/> component with <View/> component and every things working well for me.
Could you please check my gist: https://gist.github.com/nhatquya/ab2002b7ab1d578004834e7854aecfb3
Thanks!

@steveliles
Copy link
Owner

Interesting, thanks.

When you say the app crashed ... I guess you mean a "red-box" right? do you have a stack-trace?

I wasn't seeing crashes on either platform last time I ran this (it was a while ago) ... did you change anything else e.g. the React-Native version or the react-native-svg version?

@nhatquya
Copy link
Author

nhatquya commented Dec 22, 2016

My app crashed on Android:
RN: v0.39.2
react-native-svg: v4.4.1
ART: v 0.10.1

The app crashed with the "Unfortunately, MyApp has stopped" alert. it's not the React Native Red Screen.

@steveliles
Copy link
Owner

steveliles commented Dec 22, 2016

Aha, so newer React-Native and react-native-svg than I was using. Possibly you've come across a bug in the newer version of react-native-svg? (because using panhandlers on a Circle is supposed to work - and did work in the earlier version).

Moving the panhandlers to an enclosing view presumably changes the behaviour somewhat - e.g. in my version you had to be touching the circle at the end of the slider to be able to drag it, but in yours I guess you can touch anywhere - depends if that's the behaviour you want to achieve i guess.

@nhatquya
Copy link
Author

I don't know what happen on my side and i got what you mean.
I trying make feature same as your example but facing some problem with panresonder on <Circle/>.
Please keep this issues until I investigate the root cause.
Thanks!

@steveliles
Copy link
Owner

sure - thx, good luck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants