Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tech debt: ledger state snapshots should contain complete state #4607

Open
Tracked by #4318
marta-lokhova opened this issue Jan 6, 2025 · 0 comments
Open
Tracked by #4318
Assignees
Labels
bug cleanup refactoring or other internal improvements

Comments

@marta-lokhova
Copy link
Contributor

We're moving towards individual subsystems in core relying on read-only snapshots to query ledger state. There are several data structures that together comprise a complete "ledger state": the bucketlist, ledger header, and soroban config. The problem is that currently all these pieces of ledger state live in different places. Specifically, ledger header and soroban config live inside the LedgerManager, while the bucketlist lives inside of the bucketlist snapshot. This is quite error-prone and it definitely a footgun. It would be much easier to reason about consistency of ledger state snapshots if all relevant pieces lived inside of a single snapshot object. There is some WIP changes in #4597 already, which we can probably revive when we prioritize this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cleanup refactoring or other internal improvements
Projects
None yet
Development

No branches or pull requests

2 participants