Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ingest/ledgerbackend: Rerun BufferedStorageBackend benchmark tests #5497

Closed
urvisavla opened this issue Oct 29, 2024 · 1 comment
Closed

Comments

@urvisavla
Copy link
Contributor

What problem does your feature solve?

In #5390 , we ran performance benchmark tests on BufferedStorageBackend for ledger metadata files using different batch sizes to determine the optimal configuration. Since then, a fix has been made to the XDR library used for unmarshalling the downloaded files. We should re-run these benchmark tests with the fix and update configuration recommendations for BufferedStorageBackend.

What would you like to see?

Rerun benchmark tests and Adjust default Configurations based on the results.

What alternatives are there?

Let SDK users to figure out the best configurations based on their own experimentation as needed.

@urvisavla urvisavla added this to the platform sprint 52 milestone Oct 29, 2024
@urvisavla urvisavla self-assigned this Nov 12, 2024
@tamirms tamirms self-assigned this Nov 19, 2024
@urvisavla urvisavla moved this from Needs Review to In Progress in Platform Scrum Dec 3, 2024
@urvisavla
Copy link
Contributor Author

urvisavla commented Jan 8, 2025

Here are the results of benchmarking BufferedStorageBackend for various ledger sizes: BufferedStorageBackend Benchmark

  • For configurations with 1 ledger per file, scaling beyond 10 download workers and buffer size of 100 showed no significant improvement.
  • For multiple ledgers per file, ledgers per file configurations from 64 to 512 ledgers showed no significant performance improvement beyond 2 workers and a buffer size of 10.

These tests were conducted on my local machine.

Once reviewed, I can update producer.go based on the findings.

@mollykarcher mollykarcher moved this from In Progress to Needs Review in Platform Scrum Jan 14, 2025
@urvisavla urvisavla moved this from Needs Review to Done in Platform Scrum Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

4 participants