-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal to rework drama to not use tables #780
Comments
Good work. I think Using We could even avoid the extra classes by selecting However I suspect that In any case, any solution we select has to work in ADE. |
I think even if none of this shakes out, we should at least add |
I guess the next step would be to test on a physical Kindle? If you (or anyone else reading) has one I’ve attached my reworked |
Can you send the compatible epub version that I can try sending to my Kobo? |
Certainly. Here’s the compatible and Kobo variants. |
Here are some screenshots of assorted pages from an aging Kindle Paperwhite (Kindle firmware 5.6.1.1): https://photos.app.goo.gl/4C85aEA4MSxUsGj97 If any other pages or perhaps text size views would be useful just let me know. This is just at the text size and preferences I had from last reading a book. |
OK, I tried it on my very old Kindle Voyage and Kobo Aura One and they both look good. Lastly I think we should try the renderers on some of the bigger ereading apps. Google Books, Kindle app (not the same renderer as the eink Kindle), Nook app, Moon+, FBreader. (FBreader I recall has an especially bad renderer so I'm not super concerned if it doesn't look perfect in that one.) |
OK looks good. The next question is, how would we handle the @EmmaSweeney do you have any thoughts on this proposal? |
But what about multiple speakers together in one dialog? We used |
Right, yes. Let me have a think about how to handle that. In the mean time, I’ve started a branch with a |
I'm happy that we are improving the reading experience for our plays! I don't think there is anything besides the |
We currently use tables to lay out drama, but this is problematic:
We’ve attempted to work past the first problem in the past with CSS that disallows clicking on tables, but this has the side effects of breaking selection and dictionary lookup.
First attempt to properly fix this
I tried adding
role="presentation"
to the drama tables. This is the recommended fix for problem 2, and partially resolves 1, but it’s really flaky: some parts of the table no longer produce a viewer mode, but not others. I attempted to addrole="presentation"
additionally to the table rows with no luck.Second proposal
This would be considerably more work, but I think we should evaluate using
display: table
with classed divs instead. To test, I converted The Libation Bearers, replacing<table>
with<div class="drama-table">
,<tr>
with<div class="drama-row">
, and<td>
with<div class="drama-cell">
. I then added appropriatedisplay: table
/display: table-row
/display: table-cell
to local.css.Testing in Apple Books (with the viewer suppression hack removed), this looks fine:
I don’t have a physical Kindle, but I tested loading the same epub into Kindle Previewer, and it looks fine there too:
Work to be done
If we decide to go ahead with this, then the good thing is that it doesn’t need to be a big bang release. The proposed timeline would be:
Question
Worth it?
The text was updated successfully, but these errors were encountered: