Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoPilot right click context -> Review and Comment causes a 400 #477

Closed
lukehinds opened this issue Dec 31, 2024 · 7 comments
Closed

CoPilot right click context -> Review and Comment causes a 400 #477

lukehinds opened this issue Dec 31, 2024 · 7 comments
Assignees
Labels

Comments

@lukehinds
Copy link
Contributor

Describe the issue

Performing CoPilot right click context -> Review and Comment causes a 400

CoPilot Log:

2024-12-31 18:11:53.617 [error] Error: net::ERR_PROXY_CONNECTION_FAILED
    at SimpleURLLoaderWrapper.<anonymous> (node:electron/js2c/utility_init:2:10511)
    at SimpleURLLoaderWrapper.emit (node:events:518:28): Error on conversation request
2024-12-31 18:12:04.833 [info] Request ID for failed request: d8e22004-e848-4df0-992f-ec3c7bb0fbae
2024-12-31 18:12:04.837 [error] Request Failed: 400 Bad Request

2024-12-31 18:12:54.263 [info] Request ID for failed request: 82bfc0af-0cea-47bd-b94c-35f855c71116
2024-12-31 18:12:54.265 [error] Request Failed: 400 Bad Request

CoPilot Log

2024-12-31T18:12:04.3dZ [error ] Pipeline processing error: Unterminated string starting at: line 1 column 3199 (char 3198) module=pipeline pathname=/Users/lhinds/repos/stacklok/codegate-repos/codegate/src/codegate/providers/copilot/pipeline.py

Steps to Reproduce

Select code -> Right Click -> CoPilot -> Review and Comment

Operating System

MacOS (Arm)

IDE and Version

Version: 1.96.2 (Universal) Commit: fabdb6a30b49f79a7aba0f2ad9df9b399473380f

Extension and Version

1.254.0

Provider

GitHub Copilot

Model

GPT 4o

Logs

No response

Additional Context

No response

@lukehinds lukehinds added the bug label Dec 31, 2024
@lukehinds lukehinds changed the title -- Provide a general summary of the issue -- CoPilot right click context -> Review and Comment causes a 400 Dec 31, 2024
@yrobla yrobla self-assigned this Jan 2, 2025
@yrobla
Copy link
Contributor

yrobla commented Jan 2, 2025

@lukehinds can you share the piece of code you used? i tried several and got:

Image

it returns normally, telling that there is no comment

@yrobla yrobla removed their assignment Jan 2, 2025
@yrobla
Copy link
Contributor

yrobla commented Jan 8, 2025

@lukehinds are you still seeing this problem?

@lukehinds
Copy link
Contributor Author

@lukehinds to recheck

@lukehinds
Copy link
Contributor Author

This issue still persists

@blkt
Copy link
Contributor

blkt commented Jan 14, 2025

@lukehinds I tried reproducing the issue with the latest version from main using Copilot free without success (i.e. works on my machine).
We should probably look into it live.

@blkt blkt self-assigned this Jan 15, 2025
@blkt
Copy link
Contributor

blkt commented Jan 16, 2025

I dug into this issue and I believe @jhrozek solved in this commit 3e4790d, so versions v0.1.6 and above have the fix.
@lukehinds could you please ensure you're running the latest version?

@lukehinds
Copy link
Contributor Author

I just checked again and interestingly I get the same thing with no codegate proxy inline (using CoPilot direct), so I figure lets close this for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants