Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address the remaining TODOs #4

Open
2 of 73 tasks
squeek502 opened this issue Sep 20, 2023 · 0 comments
Open
2 of 73 tasks

Address the remaining TODOs #4

squeek502 opened this issue Sep 20, 2023 · 0 comments

Comments

@squeek502
Copy link
Owner

squeek502 commented Sep 20, 2023

TODOs remaining in the code:

  • ./build.zig:71:5: TODO: coverage across all test steps?
  • ./src/ani.zig:37:13: TODO: Move file cursor instead of skipBytes
  • ./src/cli.zig:758:17: TODO: More investigation to figure out what it does (if anything)
  • ./src/code_pages.zig:4:1: TODO: Parts of this comment block may be more relevant to string/NameOrOrdinal parsing
  • ./src/comments.zig:45:9: TODO: Disallow \x1A, \x00, \x7F in comments. At least \x1A and \x00 can definitely
  • ./src/compile.zig:39:5: TODO: Maybe a dedicated struct for this purpose so that it's a bit nicer to work with.
  • ./src/compile.zig:50:5: TODO: Implement verbose output
  • ./src/compile.zig:93:5: TODO: Maybe catch and return an error instead
  • ./src/compile.zig:98:13: TODO: maybe a warning that the search path is skipped?
  • ./src/compile.zig:106:13: TODO: maybe a warning that the search path is skipped?
  • ./src/compile.zig:116:9: TODO: Should this be platform-specific? How does windres/llvm-rc handle this (if at all)?
  • ./src/compile.zig:413:9: TODO: More robust checking of the validity of the filename.
  • ./src/compile.zig:657:33: TODO: Need to test V4 and V5 bitmaps to check they actually work
  • ./src/compile.zig:770:25: TODO: Make this configurable (command line option)
  • ./src/compile.zig:813:21: TODO: It might be possible that the calculation done in this function
  • ./src/compile.zig:1866:21: TODO: Maybe warn when parsed_terminated.len != parsed.len, since
  • ./src/compile.zig:1941:9: TODO: Try to find something mentioning this
  • ./src/errors.zig:471:17: TODO: Improve or maybe add a note making it more clear that the code page
  • ./src/errors.zig:507:17: TODO: Better wording? This is what the Win32 RC compiler emits.
  • ./src/errors.zig:561:17: TODO: better printing of language, using constant names from WinNT.h
  • ./src/errors.zig:605:17: TODO: Better wording
  • ./src/errors.zig:656:17: TODO: command line option
  • ./src/errors.zig:861:5: TODO: General handling of long lines, not tied to this specific error
  • ./src/fnt.zig:10:1: TODO: This is currently entirely unused. A possible use would be to add
  • ./src/fnt.zig:52:1: TODO: This seems like a somewhat strange pattern, could be a better way
  • ./src/fnt.zig:110:5: TODO: Use file cursor moving instead of skipBytes here
  • ./src/ico.zig:36:1: TODO: This seems like a somewhat strange pattern, could be a better way
  • ./src/lex.zig:87:5: TODO: This doesn't necessarily match up with how we count line numbers, but where a line starts
  • ./src/lex.zig:154:5: TODO: This is not really how the Win32 RC compiler handles line endings. Instead, it
  • ./src/lex.zig:380:5: TODO: A not-terrible name
  • ./src/lex.zig:404:9: TODO: Understand this more, bring it more in line with how the Win32 limits work.
  • ./src/lex.zig:843:13: TODO: Make sure there aren't any exceptions
  • ./src/main.zig:16:5: TODO: Reset codepage afterwards?
  • ./src/main.zig:109:17: TODO: could use --trace-includes to give info about what's included from where
  • ./src/main.zig:111:17: TODO: Turn this off, check the warnings, and convert the spaces back to NUL
  • ./src/main.zig:113:17: TODO: could remove -Werror=null-character and instead parse warnings looking for 'warning: null character ignored'
  • ./src/main.zig:116:17: TODO: could use -Werror instead
  • ./src/main.zig:143:17: TODO: This is a workaround that should be removed if possible.
  • ./src/main.zig:156:21: TODO: Should this be platform-specific? How does windres/llvm-rc handle this (if at all)?
  • ./src/main.zig:241:5: TODO: Need to test to make sure that the parsing of the #line directives match
  • ./src/parse.zig:16:1: TODO: Make these configurable?
  • ./src/parse.zig:177:21: TODO: Wrapping this in a Node.Literal is superfluous but necessary
  • ./src/parse.zig:206:21: TODO: Wrapping this in a Node.Literal is superfluous but necessary
  • ./src/parse.zig:381:13: TODO: emit warning
  • ./src/parse.zig:722:13: TODO: More fine-grained switch cases as necessary
  • ./src/parse.zig:1437:9: TODO: This could probably be done without evaluating the whole expression
  • ./src/parse.zig:1528:13: TODO: expected_types_override interaction with is_known_to_be_number_expression?
  • ./src/parse.zig:1609:17: TODO: Add context to error about where the open paren is
  • ./src/parse.zig:1664:17: TODO: Potentially re-evaluate and support the unary plus in a bug-for-bug
  • ./src/rc.zig:81:5: TODO: Some comptime validation that RT <-> Resource conversion is synced?
  • ./src/res.zig:83:5: TODO: SHARED and PURE seem to be the same thing? Testing seems to confirm this but
  • ./src/source_mapping.zig:180:5: TODO: There might be a better way around this
  • ./src/source_mapping.zig:221:1: TODO: Might want to provide diagnostics on invalid line commands instead of just returning
  • ./src/source_mapping.zig:223:5: TODO: Are there other whitespace characters that should be included?
  • ./src/utils.zig:29:1: TODO: Remove once Platform specific error.IsDir behavior in fs.Dir.openFile ziglang/zig#5732 is addressed.
  • ./test/fuzzy_accelerators.zig:4:1: TODO: Split into permutations of:
  • ./test/fuzzy_code_pages.zig:84:9: TODO: What is happening?
  • ./test/fuzzy_common_resource_attributes.zig:10:1: TODO: For each resource type as well
  • ./test/fuzzy_common_resource_attributes_map_gen.zig:12:1: TODO: For each resource type as well
  • ./test/fuzzy_raw_data.zig:33:9: TODO: Having a limited amount of trailing stuff after resource definitions is not actually an error.
  • ./test/fuzzy_raw_data.zig:35:9: TODO: ¹ ² ³ (encoded as Windows-1252) are inexplicably valid in number literals
  • ./test/fuzz_rc.zig:32:5: TODO: Better seed, maybe taking the first few bytes and interpretting as u64
  • ./test/parse.zig:2152:5: TODO: test different code pages
  • ./test/reference.zig:18:5: TODO: Figure out a better way to consistently find the ./test/files directory.
  • ./test/utils.zig:157:5: TODO: Bypass the intermediate file if options.run_preprocessor is false
  • ./test/utils.zig:193:5: TODO: Somehow make this re-usable between calls
  • ./test/utils.zig:201:9: TODO: Make this configurable
  • ./test/utils.zig:240:9: TODO: could use --trace-includes to give info about what's included from where
  • ./test/utils.zig:242:9: TODO: Turn this off, check the warnings, and convert the spaces back to NUL
  • ./test/utils.zig:244:9: TODO: could remove -Werror=null-character and instead parse warnings looking for 'warning: null character ignored'
  • ./test/utils.zig:247:9: TODO: could use -Werror instead
  • ./test/utils.zig:290:13: TODO: Make this configurable
  • ./test/utils.zig:341:5: TODO: increase this limit?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant