Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check "classifier" and regular artifact assumption and either handle or detect and report #32

Open
cgruber opened this issue Jan 29, 2019 · 1 comment
Assignees
Labels
Type-cleanup Clean code, or other code or project hygiene Type-enhancement New feature or request

Comments

@cgruber
Copy link
Collaborator

cgruber commented Jan 29, 2019

The code makes an assumption that deps sections won't have both the main artifact for a group_id/artifact_id pair AND one of the same pom's classified artifacts. It is possible, and in those cases, the deps will be wrong and the build snippet should be explicitly substituted.

We should detect this and report it, or possibly handle it.

@cgruber cgruber added Type-enhancement New feature or request Type-cleanup Clean code, or other code or project hygiene labels Jan 29, 2019
@cgruber cgruber added this to the Post 1.0 cleanup milestone Jan 29, 2019
@cgruber cgruber self-assigned this Jan 29, 2019
@cgruber
Copy link
Collaborator Author

cgruber commented Jun 2, 2020

Partial support has happened, under the hood - the underlying library has been updated to support sub-artifacts. This needs a ocnfiguration DSL - probably "classifiers": ["foo"] but it needs care, because we don't want duplicate specification. Need to look at how dependencies add classifiers, and detect that, in order to make sure everything wires up, and then allow this extra download.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type-cleanup Clean code, or other code or project hygiene Type-enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant