Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type aware canWrite() method should be called for GenericHttpMessageConverter [SPR-13161] #17752

Closed
spring-projects-issues opened this issue Jun 24, 2015 · 1 comment
Assignees
Labels
type: bug A general bug
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Jun 24, 2015

Sébastien Deleuze opened SPR-13161 and commented


Issue Links:

Referenced from: commits 289f35d

@spring-projects-issues
Copy link
Collaborator Author

Sébastien Deleuze commented

This commit introduces the following changes:

  • In AbstractMessageConverterMethodProcessor, the type aware variant of canWrite() is now called when the converter implements GenericHttpMessageConverter.
  • The Javadoc has been updated in GenericHttpMessageConverter to make it clear that the type aware canRead() and canWrite() methods should perform the same checks than non type aware ones.
  • AbstractGenericHttpMessageConverter now implements default type aware canRead() and canWrite() methods than just call the non type aware variants. Due to this, if subclasses just override the non type aware variants, they still have the right behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

No branches or pull requests

2 participants