Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rails 5.2: Bump ActiveShipping #268

Open
joshRpowell opened this issue Apr 28, 2018 · 1 comment · May be fixed by #275
Open

Rails 5.2: Bump ActiveShipping #268

joshRpowell opened this issue Apr 28, 2018 · 1 comment · May be fixed by #275

Comments

@joshRpowell
Copy link
Contributor

joshRpowell commented Apr 28, 2018 •
edited
Loading

5.2 support added here Shopify/active_shipping@9b04b51

Needs to be updated here

spree_active_shipping/spree_active_shipping.gemspec

Line 21 in b6e71bd

s.add_dependency 'active_shipping', '~> 1.4'

this looks like it will require a refactor due to:

BREAKING CHANGE: Use [shopify/measured] instead of shopify/quantified for dimensions and units.

https://github.com/Shopify/active_shipping/blob/master/CHANGELOG.md#v200

which can be found here: shopify/measured
@joshRpowell joshRpowell mentioned this issue Apr 28, 2018
Closed
@joshRpowell
Copy link
Contributor Author

@damianlegawiec @bbonislawski any suggestions/thoughts on how to proceed? Is this something you'll want up to date for the Rails 5.2 bump?

I'll gladly work up a PR. Trying not to duplicate any existing efforts.

@joshRpowell joshRpowell linked a pull request Oct 17, 2018 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] Bump ActiveShipping milner-group/spree_active_shipping
1 participant
@joshRpowell