Skip to content
This repository has been archived by the owner on Apr 17, 2021. It is now read-only.

Aggregation error doesn't show up when navigating from dashboard #79

Open
hexedpackets opened this issue Nov 4, 2019 · 1 comment
Open
Assignees
Labels
type:bug Something isn't working

Comments

@hexedpackets
Copy link
Contributor

Aggregation limits (and possibly errors) are ignored when navigating to a panel from a dashboard. The graph will show No data points without any error message, which is very confusing.

Changing the resolution or refreshing the dashboard will cause the error to appear. Navigating directly to the panel by the URL will also make the error message appear.

@hexedpackets hexedpackets added the type:bug Something isn't working label Nov 4, 2019
@ryanvazquez
Copy link
Contributor

Heroic errors can be persisted between dashboard/panel navigations within the query builder (aka inline), however these errors can't be visualized via the PanelHeaderCorner component (aka the "dogear" notification). Grafana's built-in data-error hook does not trigger the dogear notification.

In order to present the dogear notification to the user, the API response must either be rejected by the datasource via a handled or unhandled promise rejection or an error can be thrown manually. In any case, no time series data will be visualized by Grafana.

This will effectively "break" existing users' experience who may have queries that contain such errors/limits/etc - their panels will show errors but no results sets (when results existed before).

We can address this at the API level and/or the datasource could establish a set of criteria for rejecting Heroic responses if the results are unlikely to be what the user intended - and only break the experience for a narrower set of existing users with malformed queries.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants