fix: add strict mode for UriHandler #1192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When it's turned on, the handler will check all required URI segments and throw an exception if any are missing. This helps catch incomplete routes early and makes sure all params are present.
- Removes empty segments for optional parameters - Adds more patters for unit tests
butschster
commented
Jan 6, 2025
| if ($missingParameters !== []) { | ||
| throw new UriHandlerException( | ||
| \sprintf( | ||
| \count($missingParameters) === 1 |
There was a problem hiding this comment.
Refactor error message
roxblnfk
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strict mode ensures all required URI segments are validated. If any are missing, an exception is thrown.
To enable strict mode, request
Spiral\Router\UriHandlerfrom the container inRoutersBootloaderand set strict mode: