Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source contains ESP32-specific log_ prints #6

Open
PaulZC opened this issue Dec 19, 2024 · 0 comments
Open

Source contains ESP32-specific log_ prints #6

PaulZC opened this issue Dec 19, 2024 · 0 comments

Comments

@PaulZC
Copy link

PaulZC commented Dec 19, 2024

I'm seeing four uncommented log_ prints in NmeaPacket::FromString. These will cause compilation errors on non-ESP32 platforms...

https://github.com/search?q=repo%3Asparkfun%2FSparkFun_LG290P_GNSS_Arduino_Library%20log_&type=code

Time for some festive commenting...?! ;-)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PaulZC