Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Roman detector naming from SCAxy to WFIxy #3

Open
Skyhawk172 opened this issue Dec 4, 2024 · 1 comment
Open

Change Roman detector naming from SCAxy to WFIxy #3

Skyhawk172 opened this issue Dec 4, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@Skyhawk172
Copy link
Collaborator

For consistency with other Roman simulation tools as well as with the Roman pipeline, we would like to specify which detector to use with the WFIxy string instead of SCAxy.

For example, users would use the following going forward:
wfi.detector = "WFI01"

@Skyhawk172 Skyhawk172 added the enhancement New feature or request label Dec 4, 2024
@mperrin
Copy link
Collaborator

mperrin commented Dec 4, 2024

This can be done in part similarly to how we handle NRCA5 and NRCALONG, with a couple lines of code in the detector setter function to treat both values as synonyms. See https://github.com/spacetelescope/webbpsf/blob/develop/webbpsf/webbpsf_core.py#L2784

That would let existing code using "SCA01" to continue to work, while new code can be written using "WFI01", and both would behind the scenes set the detector to the same value.

@BradleySappington BradleySappington transferred this issue from spacetelescope/webbpsf Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants