Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong time-of-day in "last <date> <time-of-day interval>" #201

Open
rosastern opened this issue Oct 11, 2019 · 0 comments
Open

Wrong time-of-day in "last <date> <time-of-day interval>" #201

rosastern opened this issue Oct 11, 2019 · 0 comments
Assignees

Comments

@rosastern
Copy link
Collaborator

Initial issue reported: https://github.com/snipsco/next-release/issues/809

Parsing Error

"last wednesday between one thirty and three forty-five am" gives wrong resolution on the left side time-of-day

Version

platform v1.2, v1.3

Language

en - other languages may be impacted too

Parser input

last wednesday between one thirty and three forty-five am

Parser output

+----+------------+-------------+----------------------------------------------------+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| ix | log(p)     | p           | text                                               | Output(OutputValue)                                                                                                                                                                                |
+====+============+=============+====================================================+====================================================================================================================================================================================================+
| 0  | -3.3397157 | 0.035447035 | last wednesday between two and three forty-five am | DatetimeInterval(DatetimeIntervalOutput { interval_kind: Between { start: 2019-10-09T00:00:00+02:00, end: 2019-10-09T03:45:00+02:00, precision: Exact, latent: false }, datetime_kind: Datetime }) |
+----+------------+-------------+----------------------------------------------------+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+

Parser expected output (Optional)

+----+------------+-------------+----------------------------------------------------+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| ix | log(p)     | p           | text                                               | Output(OutputValue)                                                                                                                                                                                |
+====+============+=============+====================================================+====================================================================================================================================================================================================+
| 0  | -3.3397157 | 0.035447035 | last wednesday between two and three forty-five am | DatetimeInterval(DatetimeIntervalOutput { interval_kind: Between { start: 2019-10-09T01:30:00+02:00, end: 2019-10-09T03:45:00+02:00, precision: Exact, latent: false }, datetime_kind: Datetime }) |
+----+------------+-------------+----------------------------------------------------+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
@rosastern rosastern added the bug label Oct 11, 2019
@rosastern rosastern self-assigned this Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant