Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2K interpreted as datetime #138

Open
adrienball opened this issue Oct 16, 2018 · 2 comments
Open

2K interpreted as datetime #138

adrienball opened this issue Oct 16, 2018 · 2 comments
Assignees
Labels
bug fixpending Fix done. Version with fix will be added to ticket.

Comments

@adrienball
Copy link
Collaborator

Parsing Error

Rustling should not interpret values like "2K" as datetime.

Version

0.17.5

Language

en

Parser input

cargo run -- --lang en parse "2K" -k Time

Parser output

Time(TimeOutput { moment: 2000-01-01T00:00:00+01:00, grain: Year, precision: Exact, latent: false })

Parser expected output (Optional)

Nothing

@adrienball adrienball added the bug label Oct 16, 2018
@adrienball
Copy link
Collaborator Author

This issue was initially raised here: snipsco/snips-nlu#676

@rosastern rosastern self-assigned this Oct 23, 2018
@rosastern rosastern added the fix label Oct 23, 2018
@rosastern rosastern removed the fix label Sep 27, 2019
@rosastern
Copy link
Collaborator

rosastern commented Sep 27, 2019

This is fixed / not reproduced in current version (0.19.2)
"2K" as datetime is not the preferred resolution in the general case, but it is when restricting parsing to Datetime entity kind. Reopening to fix this behaviour

@rosastern rosastern reopened this Oct 1, 2019
@rosastern rosastern added the fixpending Fix done. Version with fix will be added to ticket. label Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fixpending Fix done. Version with fix will be added to ticket.
Projects
None yet
Development

No branches or pull requests

2 participants