diff --git a/.github/workflows/check-bioc.yml b/.github/workflows/check-bioc.yml index 47b4f7ca..09338ee6 100644 --- a/.github/workflows/check-bioc.yml +++ b/.github/workflows/check-bioc.yml @@ -141,15 +141,15 @@ jobs: ## required for ncdf4 ## brew install netcdf ## Does not work as it is compiled with gcc ## Use pre-compiled libraries from https://mac.r-project.org/libs-4/ - curl -O https://mac.r-project.org/libs-4/netcdf-4.7.4-darwin.17-x86_64.tar.gz - tar fvxzm netcdf-4.7.4-darwin.17-x86_64.tar.gz -C / - rm netcdf-4.7.4-darwin.17-x86_64.tar.gz - curl -O https://mac.r-project.org/libs-4/hdf5-1.12.0-darwin.17-x86_64.tar.gz - tar fvxzm hdf5-1.12.0-darwin.17-x86_64.tar.gz -C / - rm hdf5-1.12.0-darwin.17-x86_64.tar.gz - curl -O https://mac.r-project.org/libs-4/szip-2.1.1-darwin.17-x86_64.tar.gz - tar fvxzm szip-2.1.1-darwin.17-x86_64.tar.gz -C / - rm szip-2.1.1-darwin.17-x86_64.tar.gz + # curl -O https://mac.r-project.org/libs-4/netcdf-4.7.4-darwin.17-x86_64.tar.gz + # tar fvxzm netcdf-4.7.4-darwin.17-x86_64.tar.gz -C / + # rm netcdf-4.7.4-darwin.17-x86_64.tar.gz + # curl -O https://mac.r-project.org/libs-4/hdf5-1.12.0-darwin.17-x86_64.tar.gz + # tar fvxzm hdf5-1.12.0-darwin.17-x86_64.tar.gz -C / + # rm hdf5-1.12.0-darwin.17-x86_64.tar.gz + # curl -O https://mac.r-project.org/libs-4/szip-2.1.1-darwin.17-x86_64.tar.gz + # tar fvxzm szip-2.1.1-darwin.17-x86_64.tar.gz -C / + # rm szip-2.1.1-darwin.17-x86_64.tar.gz - name: Install Windows system dependencies if: runner.os == 'Windows' diff --git a/tests/testthat/test_Param_classes.R b/tests/testthat/test_Param_classes.R index 5a3eb6f8..4281d56f 100644 --- a/tests/testthat/test_Param_classes.R +++ b/tests/testthat/test_Param_classes.R @@ -500,7 +500,6 @@ test_that("PeakDensityParam works", { expect_error(sampleGroups(p) <- NULL) expect_error(sampleGroups(p) <- c(2, 2, NA)) expect_error(PeakDensityParam()) - expect_error(PeakDensityParam(sampleGroups = c(1, 1, NA))) p <- new("PeakDensityParam", bw = 3) expect_equal(bw(p), 3)