Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vert.x 4.5 support #852

Closed
magicprinc opened this issue Nov 18, 2023 · 3 comments
Closed

Vert.x 4.5 support #852

magicprinc opened this issue Nov 18, 2023 · 3 comments
Milestone

Comments

@magicprinc
Copy link

As you know ;-)
Vert.x 4.5 is released (Amazing, BTW)
Could you make compatible mutiny-vert.x binding please 🙏

@cescoffier
Copy link
Contributor

Unfortunately, this Vert.x release contains a few breaking changes:

Incompatible changes in vertx-mutiny-core

[cols="1,1,1,1", options="header"]
|===
| Element | Classification | Criticality | Description

| method io.smallrye.mutiny.Uni<java.lang.Void> io.vertx.mutiny.core.http.HttpClient::updateSSLOptions(io.vertx.core.net.SSLOptions) a|

  • Source: BREAKING
  • Binary: NON_BREAKING | error | The return type changed from 'io.smallrye.mutiny.Uni<java.lang.Void>' to 'io.smallrye.mutiny.Uni<java.lang.Boolean>'.

| method java.lang.Void io.vertx.mutiny.core.http.HttpClient::updateSSLOptionsAndAwait(io.vertx.core.net.SSLOptions) a|

  • Source: POTENTIALLY_BREAKING
  • Binary: BREAKING | error | The return type changed from 'java.lang.Void' to 'java.lang.Boolean'.

| method io.smallrye.mutiny.Uni<java.lang.Void> io.vertx.mutiny.core.http.HttpServer::updateSSLOptions(io.vertx.core.net.SSLOptions) a|

  • Source: BREAKING
  • Binary: NON_BREAKING | error | The return type changed from 'io.smallrye.mutiny.Uni<java.lang.Void>' to 'io.smallrye.mutiny.Uni<java.lang.Boolean>'.

| method java.lang.Void io.vertx.mutiny.core.http.HttpServer::updateSSLOptionsAndAwait(io.vertx.core.net.SSLOptions) a|

  • Source: POTENTIALLY_BREAKING
  • Binary: BREAKING | error | The return type changed from 'java.lang.Void' to 'java.lang.Boolean'.

| method io.vertx.mutiny.core.http.WebSocketBase io.vertx.mutiny.core.http.ServerWebSocket::writePingAndForget(io.vertx.mutiny.core.buffer.Buffer) a|

  • Source: NON_BREAKING
  • Binary: BREAKING | error | The return type changed covariantly from 'io.vertx.mutiny.core.http.WebSocketBase' to 'io.vertx.mutiny.core.http.ServerWebSocket'.

| method io.vertx.mutiny.core.http.WebSocketBase io.vertx.mutiny.core.http.ServerWebSocket::writePongAndForget(io.vertx.mutiny.core.buffer.Buffer) a|

  • Source: NON_BREAKING
  • Binary: BREAKING | error | The return type changed covariantly from 'io.vertx.mutiny.core.http.WebSocketBase' to 'io.vertx.mutiny.core.http.ServerWebSocket'.

| method io.vertx.mutiny.core.http.WebSocketBase io.vertx.mutiny.core.http.WebSocket::writePingAndForget(io.vertx.mutiny.core.buffer.Buffer) a|

  • Source: NON_BREAKING
  • Binary: BREAKING | error | The return type changed covariantly from 'io.vertx.mutiny.core.http.WebSocketBase' to 'io.vertx.mutiny.core.http.WebSocket'.

| method io.vertx.mutiny.core.http.WebSocketBase io.vertx.mutiny.core.http.WebSocket::writePongAndForget(io.vertx.mutiny.core.buffer.Buffer) a|

  • Source: NON_BREAKING
  • Binary: BREAKING | error | The return type changed covariantly from 'io.vertx.mutiny.core.http.WebSocketBase' to 'io.vertx.mutiny.core.http.WebSocket'.

| method io.smallrye.mutiny.Uni<java.lang.Void> io.vertx.mutiny.core.net.NetClient::updateSSLOptions(io.vertx.core.net.SSLOptions) a|

  • Source: BREAKING
  • Binary: NON_BREAKING | error | The return type changed from 'io.smallrye.mutiny.Uni<java.lang.Void>' to 'io.smallrye.mutiny.Uni<java.lang.Boolean>'.

| method java.lang.Void io.vertx.mutiny.core.net.NetClient::updateSSLOptionsAndAwait(io.vertx.core.net.SSLOptions) a|

  • Source: POTENTIALLY_BREAKING
  • Binary: BREAKING | error | The return type changed from 'java.lang.Void' to 'java.lang.Boolean'.

| method io.smallrye.mutiny.Uni<java.lang.Void> io.vertx.mutiny.core.net.NetServer::updateSSLOptions(io.vertx.core.net.SSLOptions) a|

  • Source: BREAKING
  • Binary: NON_BREAKING | error | The return type changed from 'io.smallrye.mutiny.Uni<java.lang.Void>' to 'io.smallrye.mutiny.Uni<java.lang.Boolean>'.

| method java.lang.Void io.vertx.mutiny.core.net.NetServer::updateSSLOptionsAndAwait(io.vertx.core.net.SSLOptions) a|

  • Source: POTENTIALLY_BREAKING
  • Binary: BREAKING | error | The return type changed from 'java.lang.Void' to 'java.lang.Boolean'.

|===
'''

Also, we expect more 4.4.x releases as the integration of Vert.x 4.5 in Quarkus is not going to happen before January.

I'm going to prepare a branch, I will see with @jponge how to proceed.

@cescoffier
Copy link
Contributor

See #853.

@cescoffier
Copy link
Contributor

Fixed in #853.

@cescoffier cescoffier added this to the 3.8.0 milestone Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants