Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe add entry for "what it does"? #10

Open
rugk opened this issue May 15, 2020 · 2 comments
Open

Maybe add entry for "what it does"? #10

rugk opened this issue May 15, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@rugk
Copy link
Contributor

rugk commented May 15, 2020

Like F-Droid antifeatures maybe list what "dangerous" actions it does, or what it does in general. In one short sentence, so you can estimate the risk.

E.g. like I did in #8:

What it does: It downloads the (correct) "rustup-init" binary from https://static.rust-lang.org and executes it to install rustup and rust.

@aral
Copy link
Contributor

aral commented May 19, 2020

I like the idea but I wonder about maintainability as well as ease of submitting validations. Submitting a validation should take almost no time as the person has already invested time in reviewing the script (we must respect people’s time).

That said, perhaps we can flip it on its head:

Any installation script should be doing the following:

  1. Download a binary
  2. Move it to a place on your path

If a script does anything else that’s out of the ordinary, we should ask people to note that.

Then again, if it’s doing something out of the ordinary and we feel we need to warn people about it, perhaps that’s no longer a validation but a warning. So perhaps what we need, in addition to validations, is a list of warnings: scripts that have been reviewed but are not recommended for installation due to <insert reasons here>.

@aral aral added the enhancement New feature or request label May 19, 2020
@rugk
Copy link
Contributor Author

rugk commented May 20, 2020

And 3. (possibly) execute that binary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants