Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for slackbot_response and thread_broadcast Messages #55

Closed
saethlin opened this issue Feb 13, 2018 · 5 comments
Closed

Add support for slackbot_response and thread_broadcast Messages #55

saethlin opened this issue Feb 13, 2018 · 5 comments

Comments

@saethlin
Copy link

I'm working on a patch for this, does anyone else have something?

@dten
Copy link
Contributor

dten commented Feb 13, 2018

i don't have anything

@saethlin
Copy link
Author

I have additions for these and bot_add + bot_remove at the ready, I'll send them as soon as #56 gets merged/approved.

Sidenote: It looks like the id field may be inconsistently-typed as well, but I don't have enough message volume to be sure.

@saethlin
Copy link
Author

saethlin commented Mar 24, 2018

@mthjones did a bunch of work a while back on codegen that looks like it might exist to solve this, should it?

Unfortunately it looks like the codegen tool is broken, and this project seems rather abandoned? I don't mean to be rude, but this project really needs some TLC. Is it really a good idea (in such a state) to depend on a project written in NodeJS?

@mthjones
Copy link
Member

mthjones commented Mar 24, 2018

Unfortunately it looks like the codegen tool is broken

Probably. It was hacked together before Slack had any sort of standard for their API, so the best it could do was scrape the web pages and try to generate a schema from that. Slack had no consistent API structure or versioning, so it was impossible to maintain. Looks like there's an actual schema now, so that sounds like it'd be a great starting point to improve this library and remove the NodeJS dev dependency!

@dten
Copy link
Contributor

dten commented Jul 17, 2020

these types exist now since v0.23

@dten dten closed this as completed Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants