Allow setting integration key with env var #101
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
I want to set my Pendo integration key without exposing it in a plain text
config.json
file. Following other Singer connectors, I added a few lines toutils.py
which use environment variableX_PENDO_INTEGRATION_KEY
if it exists and ifx_pendo_integration_key
isn't inconfig.json
. It'll still throw an error if neither exists.This would resolve #109.
Manual QA steps
I actually can't get any tests to run with
python -m pytest --verbose
. Can someone more familiar with this project confirm that command runs without import errors?Risks
Rollback steps
Code style
I tried to keep things as plain and explicit as possible:
But it may not the most succinct way to do it--or even the best way. Feel free to change this to a better way.