Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run: exit gracefully on errors #319

Open
fho opened this issue Apr 23, 2021 · 0 comments
Open

run: exit gracefully on errors #319

fho opened this issue Apr 23, 2021 · 0 comments
Labels
enhancement New feature or request version/master Bugs in the master branch

Comments

@fho
Copy link
Collaborator

fho commented Apr 23, 2021

The run command currently calls os.Exit() on some error conditions.
This causes an abrupt termination of all uploads and task execution that are ongoing in parallel.
E.g. if a task uploaded it's artifact successfully but did not record the result in db yet, the result gets lost.

Terminate gracefully instead, drain the goroutine pools before terminating

@fho fho added enhancement New feature or request version/master Bugs in the master branch labels Apr 23, 2021
@fho fho changed the title run: drain the worker pools before terminating run: exit gracefully on errors Apr 23, 2021
@fho fho added this to the 2.1.0 milestone May 7, 2021
@fho fho removed this from the 2.1.0 milestone Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request version/master Bugs in the master branch
1 participant