From 2d1b776f6c61db029a72e62deef81eafe34c29e9 Mon Sep 17 00:00:00 2001 From: Artem Chernyshev Date: Mon, 18 Mar 2024 16:39:04 +0300 Subject: [PATCH] fix: properly handle upgrades for the machines with invalid schematics Simple fix to not skip updating Talos if the machine schematic is empty. Signed-off-by: Artem Chernyshev --- .../omni/controllers/omni/cluster_machine_config_status.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/backend/runtime/omni/controllers/omni/cluster_machine_config_status.go b/internal/backend/runtime/omni/controllers/omni/cluster_machine_config_status.go index 2d323239..cce68882 100644 --- a/internal/backend/runtime/omni/controllers/omni/cluster_machine_config_status.go +++ b/internal/backend/runtime/omni/controllers/omni/cluster_machine_config_status.go @@ -129,7 +129,7 @@ func NewClusterMachineConfigStatusController() *ClusterMachineConfigStatusContro machineStatus.TypedSpec().Value.Schematic.Id != expectedSchematic // don't run the upgrade check if the running version and expected versions match - if versionMismatch && talosVersion.TypedSpec().Value.TalosVersion != "" && talosVersion.TypedSpec().Value.SchematicId != "" { + if versionMismatch && talosVersion.TypedSpec().Value.TalosVersion != "" { inSync, err := handler.syncTalosVersionAndSchematic(ctx, configStatus, machineStatus, machineConfig, statusSnapshot, talosVersion) if err != nil { return err