-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
file name error #18
Comments
Indeed, the build file is missing the .min.js ending therefore the filter isn't working and throws errors to the console:
Renaming |
this look like a dead project sadly, looking on the history this may be fix in 4 years, anyone who use this plugin in the mean time, just rename the build JS file and the plugin still works, as i see the changes in moodle 4.0 you need a other option then.. |
Hello chaps. You're welcome to do a pull request. It's important to note that the plugin does work under normal operation, it's just the debug situation you're talking about. Plugin was updated a few months ago, so clearly not a "dead project", what a ridiculous comment. Moodle 4 isn't out yet. I'm sure I'll be checking when it arrives. If, in the meantime, you wish highlight which changes in Moodle 4 will affect this plugin, then that would be very useful indeed. |
the amd/build/hljs.js file is missing the .min.js, and this is a big problem when you are in debug mode in moddle, then the plugin just don't work
this is becuase require.php is looking for the amd/build/hkjs.min.js and replace the build and min.js part to find the src/dev version of the file
the fix is easy just rename the amd/build/hljs.js file to amd/build/hljs.min.js
The text was updated successfully, but these errors were encountered: