Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file name error #18

Open
pbryitu opened this issue Sep 30, 2021 · 3 comments
Open

file name error #18

pbryitu opened this issue Sep 30, 2021 · 3 comments

Comments

@pbryitu
Copy link

pbryitu commented Sep 30, 2021

the amd/build/hljs.js file is missing the .min.js, and this is a big problem when you are in debug mode in moddle, then the plugin just don't work

this is becuase require.php is looking for the amd/build/hkjs.min.js and replace the build and min.js part to find the src/dev version of the file

the fix is easy just rename the amd/build/hljs.js file to amd/build/hljs.min.js

@dnutzz
Copy link

dnutzz commented Oct 12, 2021

Indeed, the build file is missing the .min.js ending therefore the filter isn't working and throws errors to the console:

require.js:1961 GET http://localhost/lib/requirejs.php/-1/filter_syntaxhighlighter/hljs.js net::ERR_ABORTED 404 (not found)

Renaming amd/build/hljs.js to amd/build/hljs.min.js solves the problem. Could you please update this in your source code?

@pbryitu
Copy link
Author

pbryitu commented Oct 18, 2021

this look like a dead project sadly, looking on the history this may be fix in 4 years, anyone who use this plugin in the mean time, just rename the build JS file and the plugin still works, as i see the changes in moodle 4.0 you need a other option then..

@sharpchi
Copy link
Owner

Hello chaps. You're welcome to do a pull request. It's important to note that the plugin does work under normal operation, it's just the debug situation you're talking about. Plugin was updated a few months ago, so clearly not a "dead project", what a ridiculous comment.

Moodle 4 isn't out yet. I'm sure I'll be checking when it arrives. If, in the meantime, you wish highlight which changes in Moodle 4 will affect this plugin, then that would be very useful indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants