Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sink property for emit task #1026

Closed
modoodalvi opened this issue Oct 29, 2024 · 1 comment · Fixed by #1047
Closed

Add sink property for emit task #1026

modoodalvi opened this issue Oct 29, 2024 · 1 comment · Fixed by #1047
Assignees
Labels
area: spec Changes in the Specification change: feature New feature or request. Impacts in a minor version change
Milestone

Comments

@modoodalvi
Copy link

Emit task allows workflows to publish events to event brokers or messaging systems.

However, based on the broker the runtime has to decide which sink to use. This information is missing in the emit task.

Proposal:

do:
  - emit:
      sink: 
        endpoint: 
          uri: https://mycoolendpoint.com/
          authentication: ...
      event:
        with:
          type: ...
          source: ...

Why is header or content based routing not enough?

Header or content based routing is done at the broker. For some brokers, the decision which sink / channel / topic / event bus to pick has to come first, before routing rules at these resources are applied.

The (domain) event should not contain routing information.

@cdavernas cdavernas self-assigned this Oct 29, 2024
@cdavernas cdavernas added change: feature New feature or request. Impacts in a minor version change area: spec Changes in the Specification labels Oct 29, 2024
@cdavernas cdavernas added this to the v1.0.0 milestone Oct 29, 2024
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot closed this as completed Jan 4, 2025
@github-project-automation github-project-automation bot moved this from Backlog to Done in Progress Tracker Jan 4, 2025
@cdavernas cdavernas reopened this Jan 4, 2025
@github-project-automation github-project-automation bot moved this from Done to Backlog in Progress Tracker Jan 4, 2025
@cdavernas cdavernas linked a pull request Jan 8, 2025 that will close this issue
8 tasks
@github-project-automation github-project-automation bot moved this from Backlog to Done in Progress Tracker Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: spec Changes in the Specification change: feature New feature or request. Impacts in a minor version change
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants