Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handler still does internal filtering #78

Open
asachs01 opened this issue Nov 20, 2018 · 0 comments
Open

Handler still does internal filtering #78

asachs01 opened this issue Nov 20, 2018 · 0 comments

Comments

@asachs01
Copy link
Contributor

{
    "timestamp": "2018-11-19T16:22:34.639264-0600",
    "level": "info",
    "message": "handler output",
    "handler": {
        "type": "pipe",
        "command": "/opt/sensu/embedded/bin/handler-mailer.rb",
        "name": "mailer"
    },
    "event": {
        "id": "ae98f83c-976f-494d-9dea-823cd20b9d18"
    },
    "output": [
        "warning: event filtering in sensu-plugin is deprecated, see http://bit.ly/sensu-plugin warning: occurrence filtering in sensu-plugin is deprecated, see http://bit.ly/sensu-plugin only handling every 60 occurrences: sensu.sachshaus.local/testing_error"
    ]
}

^ seems to indicate that this plugin still does internal filtering a la the "handling every 60 occurrences". Ideally, this would use the newer version of the sensu-plugin gem (iirc, it's at 2.7.0). I know the current way to do things is to use refresh, but this seems to be an unnecessary step when bumping up the version fixes the issue. I see there's already been #45 and #26 discussing the issue, but not the fact that there does appear to be filtering behavior present and active inside the plugin. I'll submit a PR shortly to remedy the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant