From acaa33986cf2726d634a195854daf5a6a4a8b97f Mon Sep 17 00:00:00 2001 From: sebranchett Date: Tue, 17 Oct 2023 10:05:08 +0200 Subject: [PATCH] remove implicit requirement and follow documentation --- single_user_docker/jupyter_server_config.py | 9 ++------- single_user_docker/requirements.txt | 1 - 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/single_user_docker/jupyter_server_config.py b/single_user_docker/jupyter_server_config.py index 65dfe17..2f020a0 100644 --- a/single_user_docker/jupyter_server_config.py +++ b/single_user_docker/jupyter_server_config.py @@ -1,14 +1,9 @@ # Configuration file for jupyter-server. -from jupyter_client.localinterfaces import public_ips c = get_config() -# Where am I? -# this from: https://github.com/jupyterhub/dockerspawner/issues/198 -# "nils-werner commented on Jul 12, 2018" -ip = public_ips()[0] -# The IP address the Jupyter server will listen on -c.ServerApp.ip = ip +# Set ip to '*' to bind on all interfaces (ips) for the hub server +c.ServerApp.ip = '*' # The port the server will listen on (env: JUPYTER_PORT) c.ServerApp.port = 8888 diff --git a/single_user_docker/requirements.txt b/single_user_docker/requirements.txt index b4d1d6f..27e9725 100644 --- a/single_user_docker/requirements.txt +++ b/single_user_docker/requirements.txt @@ -1,3 +1,2 @@ -jupyter_client jupyter-server-proxy git+https://github.com/sebranchett/pluto-on-jupyterlab.git