-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logo images look small in supported devices component #426
Comments
SupportedDevicesTable
- Logo images look small in supported devices component
SupportedDevicesTable
- Logo images look small in supported devices component
@miken-seam @razor-x is there an updated design for this? |
@codetheweb Will the updates to the devicedb images solve this or help here? |
Yes and no. The yes-part: Right now people are grabbing manufacturer logo and device images in random places and putting them in their respective projects (components, console...etc). So we clearly have many sources of truth, which leads to these issues. In principle, device-db solves the problem by unifying on a single image for each device. The no-part: EXCEPT device-db doesn't have a strong authority/guidance on how sizing/padding should be handled between all devices. All device images are squares. But some device images have padding. Others do not. This leads to inconsistency in our UI. Below is a beautiful example of this visual inconsistency (which you can see live here. Notice how devices are all squares of equal sizes, but that the devices vary quite a bit. The device images are pulled from the new device-db. Proposed Solution: I think @miken-seam needs to define guidelines on device image, logo images...etc with respect to padding, filtering...etc. Then we fix all images that get uploaded to device-db, and then devices should look much more uniform. Hope this makes sense! |
Issues:
Solution:
Modified header design:
I can do a modified header design using the horizontal logos that we used in the dashboard linked accounts page. https://dashboard.seam.co/linked-accounts
So I'll assign myself this to do the modified design, but @sybohy one of the issues is the inconsistency of the device images (which are only 96x96 in this case). How can we create and maintain a single set of device images that are balanced optically?
cc @sybohy
The text was updated successfully, but these errors were encountered: