-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement: skip structural witin
commitment & PCS
#654
Labels
Comments
hero78119
changed the title
optimisation: skip structural
optimisation: skip structural Nov 29, 2024
witin
commitmentwitin
commitment & PCS
hero78119
changed the title
optimisation: skip structural
enhancement: skip structural Nov 29, 2024
witin
commitment & PCSwitin
commitment & PCS
Thanks for the detailed writeup. |
10to4
added a commit
to 10to4/ceno
that referenced
this issue
Dec 10, 2024
10to4
added a commit
to 10to4/ceno
that referenced
this issue
Dec 10, 2024
10to4
added a commit
to 10to4/ceno
that referenced
this issue
Dec 12, 2024
- Add check for structural witnesses
10to4
added a commit
to 10to4/ceno
that referenced
this issue
Dec 12, 2024
- Modify create_structural_witin() & create_witin() to improve readability
10to4
added a commit
to 10to4/ceno
that referenced
this issue
Dec 16, 2024
- Remove SetTableAddrType - Add more meta information in StructuralWitIn - Remove from_expr
10to4
added a commit
to 10to4/ceno
that referenced
this issue
Dec 20, 2024
10to4
added a commit
to 10to4/ceno
that referenced
this issue
Dec 23, 2024
- StructuralWitIn: Addr -> u32 - Combine witness RowMajorMatrix and structural witness RowMajorMatrix
10to4
added a commit
to 10to4/ceno
that referenced
this issue
Dec 23, 2024
Modify annotations for StructuralWitIn
10to4
added a commit
to 10to4/ceno
that referenced
this issue
Dec 24, 2024
github-merge-queue bot
pushed a commit
that referenced
this issue
Dec 26, 2024
Work for #654 --------- Co-authored-by: sm.wu <[email protected]> Co-authored-by: Matthias Görgens <[email protected]> Co-authored-by: Ho <[email protected]> Co-authored-by: mcalancea <[email protected]> Co-authored-by: noelwei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Purpose
This issue is for further enhancement to skip structural
witin
commitment & PCS.Context
In current backend for dynamic non-uniform memory
addr
witin, it's a well-form MLE, and in lasso we called itstructural table
ceno/ceno_zkvm/src/tables/ram/ram_impl.rs
Line 299 in cec7b82
As verifier can evaluate structural table succinctly without rely on PCS.
Which also imply we can
For now, we already support verifier directly evaluated it.
ceno/ceno_zkvm/src/scheme/verifier.rs
Lines 724 to 735 in cec7b82
But as its a normal witin, in PCS we still do the commitment, and create/verify its PCS.
Proposed Methodology
One solution is to introduce a new expression type e.g.
Structural
polynomial type to represent this witin, similar toExpression::Constant
orExpression::Fix
. With this new type, we can make PCS skip its commitment & evaluation.Similar idea proposed in #573
A soundness noted
We need to add "rw_hints_num_vars"
ceno/ceno_zkvm/src/scheme.rs
Line 61 in cec7b82
An add-on to #542
The text was updated successfully, but these errors were encountered: